Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Added spellchecking during build #998

Merged
merged 1 commit into from
Nov 27, 2015
Merged

Added spellchecking during build #998

merged 1 commit into from
Nov 27, 2015

Conversation

mwils
Copy link
Contributor

@mwils mwils commented Nov 20, 2015

Using gem middleman-spellcheck
Added allowed wordlist
Added info to README

Fixes #948.

@mwils
Copy link
Contributor Author

mwils commented Nov 20, 2015

I have pull requests (minivan/middleman-spellcheck#25 & minivan/middleman-spellcheck#23) in for the changes to middleman-spellcheck. When the changes are merged I will make a pull request to update the gemfile here.

``` sh
brew install aspell --with-lang-en
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should put in something about Linux and Windows?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During build, Middleman will require Aspell to look for misspellings. On Macs, it can be installed via Homebrew:

brew install aspell --with-lang-en

On Windows, you can download an installer, but unfortunately it is unmaintained. On Linux, you can install with your distribution's package manager. On all platforms, you can also build the most recent version from source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I will add some instructions to the README for Linux and Windows.

@michaelrkn
Copy link
Contributor

This looks great, @mwils! Thanks for your work.

@michaelrkn
Copy link
Contributor

One other thing - there are some words in the exceptions list that look a bit strange to me, like actionhttp and allget. I couldn't find these words in the rest of the project.

@mwils
Copy link
Contributor Author

mwils commented Nov 21, 2015

Welcome.
I think the spellchecker is throwing together some words that are only separated by a tag. I will fix the bug and remove the words from the list.
It may be a bit before I can look at it. Should I amend the changes to this commit or make a new commit?

@michaelrkn michaelrkn changed the title Added spellchecking during build - closes #948 Added spellchecking during build Nov 21, 2015
@michaelrkn
Copy link
Contributor

Why don't you just update the README, and then come back to fixing the spellchecker when you have time?

@mwils
Copy link
Contributor Author

mwils commented Nov 22, 2015

Will do

@mwils
Copy link
Contributor Author

mwils commented Nov 24, 2015

Updated the README.

@michaelrkn
Copy link
Contributor

Thanks! Can you just add jQuery's so that the build will pass now? :)

Using gem middleman-spellcheck
Added allowed wordlist
Added info to README
@mwils
Copy link
Contributor Author

mwils commented Nov 26, 2015

Welcome

michaelrkn added a commit that referenced this pull request Nov 27, 2015
Added spellchecking during build
@michaelrkn michaelrkn merged commit 7d363cd into emberjs:master Nov 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants